fix rocksdb for use with global tables or tables that use_partitioner #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…produce to c hangelog topics
patkivikram
approved these changes
Apr 15, 2021
|
the linting is failing can you run ./scripts/lint? |
added 2 commits
April 16, 2021 19:16
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment when using global tables or use_partitioner for a table and rocksdb store a get won't return the value when the partition of the key to be retrieved is not the same (in terms of the partitioner) as the partition of the event that led to storing the key. This is a (imperformant) fix that in my understanding always searches in all partitions of rocksdb for the key when using global table or use_partitioner.